Skip to content

Fix color tables in docs 1878 #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 10, 2024
Merged

Fix color tables in docs 1878 #2007

merged 19 commits into from
Mar 10, 2024

Conversation

@sabadam32
Copy link
Contributor

@sabadam32 sabadam32 commented Mar 3, 2024 •
edited
Loading

Fixes #1429

@pushfoo
Copy link
Member

pushfoo commented Mar 3, 2024

One tiny question: what's the source of the checker grid image? Did you make it, or pull it from somewhere?

@sabadam32
Copy link
Contributor Author

sabadam32 commented Mar 3, 2024

I made checker.png myself

@sabadam32 sabadam32 mentioned this pull request Mar 4, 2024
Closed
pushfoo
pushfoo approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds locally and looks good. Thank you for reducing the size of the checkerboard image.

If you rephrase the PR's description to include the following, it'll auto-close the linked issue when merged:

Fixes #1878

I'm not sure if the current phrasing will get picked up by GitHub's automation.

As to parsing vs using Python's various built-ins, I think we should leave that as-is until after 3.0. I'm painfully aware of how ugly doc build is right now, and it'll take a long time to fix.

@einarf
Copy link
Member

einarf commented Mar 7, 2024

This still WIP or done?

@pushfoo
Copy link
Member

pushfoo commented Mar 7, 2024

@einarf I haven't built it recently, but I'm satisfied with it as-is, and was as of a few versions ago.

pushfoo
pushfoo approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@pushfoo pushfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran build. It looks good. 👍

@einarf einarf merged commit e2d9567 into pythonarcade:development Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pushfoo pushfoo pushfoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add gray checkerboard background under color swatches

4 participants

@sabadam32 @pushfoo @einarf @rich-saupe